Original blog post fascinating. That is some REALLY bad code design, like really bad. Amazing work finding and fixing it without source, but that should have been caught and fixed before release...let alone linger for almost a decade knowing that people literally don't play that game because of its load times. I don't think it would be completely unreasonable to say they've missed out on tens (more?) of millions of dollars because of this.
They literally already have a unique hash for each object...but they check every single item in the array. Hash tables/maps are like, sophmore (junior?) CS major topics...an intern would have caught this.
Edit: oh god I just realized I sound like someone on stack overflow what have I become
I can't find any hard confirmation in news articles but back in 2013 the game size was 72 gb. Today it's a bit over 100. This was unacceptable code in 2013 and it's sure as hell unacceptable now, and I'm tired of Rockstar constantly being excused for making the worst ports in the industry to the PC and then blaming the PC for the problems they inflicted on the port through either indifferent laziness or malicious laziness.
This is the most profitable entertainment product ever produced in human history. There is no excuse for this.
The one time I dipped my toes into FiveM, the server had some kind of essay-form written application, which I failed because I didn't know what a couple slash commands specific to that server did. I imagine there are some more casual servers out there but some of them need to chill out.
It's funny to see that some people believe that fixing and publishing a patch for a game shouldn't take more than a day.
You have no idea the horror of trying to modify code written 20 years ago.Two things to remember:
1. For nowadays programming practices, 20 years ago you'd be shot. Nowadays everyone thinks he's a programmer and deserves a 6-figure salary.
2. You can never speed up thing significantly, unless you (or someone before you) didn't previously royally screw up things.
You have no idea the horror of trying to modify code written 20 years ago.
The only reason why code was "cleaner" back then is because there was much less code. Nowadays you are expected to write tens or hundreds of more lines of code in the same amount of time. Time to add comments and do proper documentation is a luxury.